News contain invalid HTML tags

Platform, device version and operating system:
PC (but actually does not matter)

Screenshot or image:
grafik
</br> being the culprit here, highlighted red

What you were expecting to happen, and what actually happened:
I am using the RSS to display a teaser of the news within my Discord bot. While parsing the HTML, I stumbled upon the above invalid tag </br>, which cannot be properly understood by feed parsers, and thus is ommitted. This breaks formatting.
I expect the tag either to be <br> or <br />.
The official W3C validator also lists this as an error.

How often does this happen? When did it begin happening?
This is the second time that I am observing this.

Steps to make it happen again

  1. Subscribe to Gems of War with a RSS feed reader
  2. Select today’s news (Web Of Shadows)
  3. Either: Apply a HTML to Markdown converter to the formatting or just view the source of the website
  4. Important newlines are missing now

This is more a reminder for future news posts. Please don’t mess up the HTML, so that the structure can be properly inferred and the post is not garbled upon arrival in Discord.

Cheers, Gary

//edit: while I posted this, a new news article was posted, with the same problem as described.

3 Likes

We haven;t changed our formatting, so this might be an issue with the client. Unfortunately this isn’t a bug that takes priority for fixing, so it may not be resolved for a while.

Hey Saltypatra, thanks for reporting. I checked this on manual downloads as well, so it’s not the client. The above screenshot was in fact taken from a browser window viewing the news.

Update: Not only does this still exist, but today there was a new case of invalid characters occurring, which even made your own news feed choke: <3. It was written plainly into the website’s HTML, which browsers will tolerate, even though it’s broken (screenshot 1, source code of New Pet – – Gems of War) //edit ironic side note: even the forum preview of the link chokes on the proper title...
grafik

and in the feed, fetched from Gems of War, it is completeley scrubbed from existence, screenshot 2, title of the feed, &#8211; is a dash:
grafik
expected contents: <title>New Pet &#8211; &lt;3 (Nintendo Switch)</title>

In total, the news feed is chopped off at the invalid character, so you can’t even see whether this is PC or Switch news.

Cheers, Gary.

3 Likes

Half off-topic:
The bounty news for this weekend is completely weird. Everything is fine with Hound of Yao Guai, but the other one has a couple of mistakes:

  • The title does not indicate Nintendo Switch, so going to https://gemsofwar.com/news/ gives you unclear information about the platform (also my bot can’t tell, so PC players got two posts, Switch players got none)
  • The Ice Wraith posting for Switch has mixed content: Both Ice Wraith and Ogress are mentioned, and a picture of Ogress is showing:
  • Needless to say that the broken html tags are still in there: grafik

Cheers, Gary.

1 Like

Thanks for letting me know!

2 Likes

thank you, this seems to be fixed now, marking it accordingly.

3 Likes

This issue has resurfaced, and is not fixed. Last found in here (2023-04-09): On the Right Track (Nintendo Switch) – Gems of War

grafik

Cheers, Gary.

1 Like

Hi,

sorry for loitering around in this thread, but the problem does not only persist with re-used Switch news posts, but also with freshly created ones, see Campaign Begins: Aravatar’s Skull – Gems of War

And again, even the forum does not show up the usual preview, because the HTML is broken and invalid. Further proof for this, other than my word, and the red highlighting from any browser’s source code view is the official W3C validator results. There you can see that the document does not validate to be a working HTML5 page.
It’s not unlikely that this also brings a proper SEO impact to your overall site.

Cheers, Gary.

2 Likes

Sorry, I thought I’d replied here. This is on the list but with the game updates at the moment it is not at the top of the list. We will look at it as soon as we’re able.

2 Likes

Not to be disrespectful, but Gary is a well know member and contributor to this community. Also super tech savvy. Telling him it takes more than a few minutes to fix some extra HTML tags is… well, insulting?

2 Likes

Thank you :slight_smile:

I don’t take that as an insult. I know that the “fix” itself might only take a few seconds, but there is a whole business process around it. I feel like I should elaborate on what this usually looks like (though I can’t speak for IP2 / 505 in particular, I think it’s somewhat similar).

Lean back, and let me tell you the story of a very quick change on the website of a random company.

The website is hosted on an ancient instance of Wordpress. Before you can even think of changing something, you need to find the contact within the company who is able to provide a login to the backend, where changes can be done. Sometimes this even lies within a 3rd party company, as this is seldomly self hosted.

But either way, once you gain access to the backend, you’ll quickly find that there is only content there, no actual source code. The broken source code is stored within either a plugin, or a theme / template within the backend, that needs to be first identified, and subsequently changed and patched. Now with Wordpress you have the challenge that many of the plugin / theme authors mix content with PHP source code. So you can’t just move in and change something, because it could break the surroundings - in particular if the resulting broken code is somehow generated through the PHP.
So what to do now? You clone the Wordpress instance, patch that, test it properly, then move back the changes into the real website.
Yes the actual change takes only 10 seconds, but the whole above ordeal gets you busy for days before this is finally fixed. All including running around and finding people who can get you to the next step, and while maybe not even having PHP developers on the team.

TLDR; So all that Kafka told me was the priority of this compared to other stuff that could be done within the same timeframe is lower. She managed my expectations of “hey this could be done within the hour” to “it can take some longer before we pick it up”, which is good, because now I will stay patient for a while.

Hope that sheds some light on why I don’t see that as insulting.

Cheers, Gary.

7 Likes

Totally can resonate with your story :wink: Seen it many times, see it daily still.

Insulting- probl was a wrong choice of words :wink: However, i would think their source code is a bit more tight. If i try to start imagining their code looking that bad that they can’t change a simple html tag, oh well, then i can understand some of the other bugs that are coming back sometimes or introduced randomly every know an then.

1 Like